This repository was archived by the owner on May 6, 2024. It is now read-only.
[BD-13][BB-6735] refactor: rename hidden_module.HiddenDescriptor -> hidden_block.HiddenBlock - #6833
Merged
pomegranited merged 1 commit intoDec 20, 2022
Conversation
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @0x29a! When this pull request is ready, tag your edX technical lead. |
0x29a
force-pushed
the
0x29a/bb6735/unify_xblock_naming
branch
from
November 12, 2022 17:39
9c87857 to
3d842ac
Compare
Agrendalath
approved these changes
Nov 22, 2022
Agrendalath
left a comment
Agrendalath
left a comment
Contributor
There was a problem hiding this comment.
👍
- I tested this: tested in openedx/openedx-platform#31113
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
|
@jristau1984: is there a corresponding configuration like this in edx-internal? |
|
@ormsbee it looks like there are alternate versions in edx-internal for |
Agrendalath
force-pushed
the
0x29a/bb6735/unify_xblock_naming
branch
from
December 19, 2022 15:57
3d842ac to
2468e53
Compare
pomegranited
approved these changes
Dec 20, 2022
pomegranited
left a comment
pomegranited
left a comment
Contributor
There was a problem hiding this comment.
👍 -- I will merge this tomorrow if there are no objections.
- I tested this by deploying a new appserver for https://extpr31113.sandbox.opencraft.hosting/ using this configuration branch.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
I made sure any change in configuration variables is reflected in the correspondingN/A
client'sconfiguration-securerepository.
|
@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
jdmulloy
pushed a commit
that referenced
this pull request
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a part of the change done in openedx/openedx-platform#31113. It updates the path to
HiddenDescriptormodule.Testing instructions
Same as for openedx/openedx-platform#31113.